Infra iam enforcer service accounts - #36215
Conversation
…the project_id, this is because we do not want to track gcp's service accounts
Summary of ChangesHello @ksobrenat32, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial refinement to the infrastructure's IAM policy compliance system. By implementing project-specific filtering for service accounts, the system now accurately processes and enforces policies only for relevant entities, preventing cross-project service accounts from affecting compliance reports. Concurrently, the PR updates the foundational IAM permissions configuration, reflecting the latest access controls for various service accounts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
R: @pabloem |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
lgtm |
2 participants
This pull request updates the IAM policy compliance logic to ensure that only service accounts belonging to the current project are considered during compliance checks and exports. The main changes add filtering to skip service accounts that do not match the project ID, improving the accuracy and relevance of IAM policy enforcement.
The PR also updates the general permissions.